WIP: 🌱 remove no longer required grpc replace (issue: #3284)#3529
WIP: 🌱 remove no longer required grpc replace (issue: #3284)#3529camilamacedo86 wants to merge 1 commit intooperator-framework:masterfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
camilamacedo86
changed the title
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
grpc-fix-replace
branch
from
d24dbb4 to
b7965e6
Compare
camilamacedo86
force-pushed
the
grpc-fix-replace
branch
from
b7965e6 to
bf220e4
Compare
Motivation: operator-framework/operator-lifecycle-manager#3529 (comment) Upstream-repository: operator-lifecycle-manager Upstream-commit: 5d3239d70edbdfa051c41db517698d355cb5c4a7
Motivation: operator-framework/operator-lifecycle-manager#3529 (comment) Upstream-repository: operator-lifecycle-manager Upstream-commit: 5d3239d70edbdfa051c41db517698d355cb5c4a7
Motivation: operator-framework/operator-lifecycle-manager#3529 (comment) Upstream-repository: operator-lifecycle-manager Upstream-commit: 5d3239d70edbdfa051c41db517698d355cb5c4a7
openshift-merge-robot
added
the
needs-rebase
camilamacedo86
force-pushed
the
grpc-fix-replace
branch
from
bf220e4 to
af5502b
Compare
openshift-merge-robot
removed
the
needs-rebase
camilamacedo86
force-pushed
the
grpc-fix-replace
branch
2 times, most recently
from
87be2e2 to
fdc4da1
Compare
openshift-merge-robot
added
the
needs-rebase
| } | ||
|
|
||
| return grpc.Dial(address, dialOptions...) | ||
| return grpc.NewClient(address, dialOptions...) |
There was a problem hiding this comment.
I'm not sure we should make this change. I see that grpc.Dial is deprecated, but reading the GoDoc of grpc.DialContext (which is called by grpc.Dial), it sounds like there are subtle differences that may matter to us:
// One subtle difference between NewClient and Dial and DialContext is that the
// former uses "dns" as the default name resolver, while the latter use
// "passthrough" for backward compatibility. This distinction should not matter
// to most users, but could matter to legacy users that specify a custom dialer
// and expect it to receive the target string directly.
We do use a custom dialer if there is a proxyURL.
camilamacedo86
force-pushed
the
grpc-fix-replace
branch
from
fdc4da1 to
a8886c7
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-merge-robot
removed
the
needs-rebase
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
Closes: #3284